ethernet: s2io: Use skb_put_data() instead of skb_put/memcpy pair
authorShang XiaoJing <shangxiaojing@huawei.com>
Tue, 27 Sep 2022 02:28:02 +0000 (10:28 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 29 Sep 2022 07:19:09 +0000 (09:19 +0200)
Use skb_put_data() instead of skb_put() and memcpy(), which is shorter
and clear. Drop the tmp variable that is not needed any more.

Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Link: https://lore.kernel.org/r/20220927022802.16050-1-shangxiaojing@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/neterion/s2io.c

index 804354e..dcf8212 100644 (file)
@@ -7359,10 +7359,9 @@ static int rx_osm_handler(struct ring_info *ring_data, struct RxD_t * rxdp)
                int get_off = ring_data->rx_curr_get_info.offset;
                int buf0_len = RXD_GET_BUFFER0_SIZE_3(rxdp->Control_2);
                int buf2_len = RXD_GET_BUFFER2_SIZE_3(rxdp->Control_2);
-               unsigned char *buff = skb_push(skb, buf0_len);
 
                struct buffAdd *ba = &ring_data->ba[get_block][get_off];
-               memcpy(buff, ba->ba_0, buf0_len);
+               skb_put_data(skb, ba->ba_0, buf0_len);
                skb_put(skb, buf2_len);
        }