remoteproc: sysfs: Use sysfs_emit instead of sprintf
authorRaghavendra Rao Ananta <rananta@codeaurora.org>
Wed, 3 Mar 2021 21:47:02 +0000 (13:47 -0800)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Mon, 8 Mar 2021 18:27:21 +0000 (12:27 -0600)
For security reasons sysfs_emit() is preferred over sprintf().
Hence, convert the remoteproc's sysfs show functions accordingly.

Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
Link: https://lore.kernel.org/r/1614808022-26062-1-git-send-email-sidgup@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/remoteproc_sysfs.c

index 1dbef89..6840dad 100644 (file)
@@ -15,7 +15,7 @@ static ssize_t recovery_show(struct device *dev,
 {
        struct rproc *rproc = to_rproc(dev);
 
-       return sprintf(buf, "%s", rproc->recovery_disabled ? "disabled\n" : "enabled\n");
+       return sysfs_emit(buf, "%s", rproc->recovery_disabled ? "disabled\n" : "enabled\n");
 }
 
 /*
@@ -82,7 +82,7 @@ static ssize_t coredump_show(struct device *dev,
 {
        struct rproc *rproc = to_rproc(dev);
 
-       return sprintf(buf, "%s\n", rproc_coredump_str[rproc->dump_conf]);
+       return sysfs_emit(buf, "%s\n", rproc_coredump_str[rproc->dump_conf]);
 }
 
 /*