net: ixp4xx_eth: Use DEFINE_SPINLOCK() for spinlock
authorZheng Yongjun <zhengyongjun3@huawei.com>
Tue, 29 Dec 2020 13:49:47 +0000 (21:49 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 5 Jan 2021 23:43:41 +0000 (15:43 -0800)
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/xscale/ixp4xx_eth.c

index 2e52029..0152f1e 100644 (file)
@@ -247,7 +247,7 @@ static inline void memcpy_swab32(u32 *dest, u32 *src, int cnt)
 }
 #endif
 
-static spinlock_t mdio_lock;
+static DEFINE_SPINLOCK(mdio_lock);
 static struct eth_regs __iomem *mdio_regs; /* mdio command and status only */
 static struct mii_bus *mdio_bus;
 static int ports_open;
@@ -528,7 +528,6 @@ static int ixp4xx_mdio_register(struct eth_regs __iomem *regs)
 
        mdio_regs = regs;
        __raw_writel(DEFAULT_CORE_CNTRL, &mdio_regs->core_control);
-       spin_lock_init(&mdio_lock);
        mdio_bus->name = "IXP4xx MII Bus";
        mdio_bus->read = &ixp4xx_mdio_read;
        mdio_bus->write = &ixp4xx_mdio_write;