ucc_geth: Intialize link state to down before register_netdev
authorCliff Clark <cliff_clark@selinc.com>
Tue, 24 Mar 2015 21:07:26 +0000 (14:07 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Mar 2015 22:02:48 +0000 (18:02 -0400)
ucc_geth was indicating link up after a port is administratively enabled even
when nothing is plugged in.  This causes user-space tools to see a spurious link
up the first time after boot.

Signed-off-by: Cliff Clark <cliff_clark@selinc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/ucc_geth.c

index 357e8b5..56b774d 100644 (file)
@@ -3893,6 +3893,9 @@ static int ucc_geth_probe(struct platform_device* ofdev)
        ugeth->phy_interface = phy_interface;
        ugeth->max_speed = max_speed;
 
+       /* Carrier starts down, phylib will bring it up */
+       netif_carrier_off(dev);
+
        err = register_netdev(dev);
        if (err) {
                if (netif_msg_probe(ugeth))