usb: typec: mux: Allow muxes to specify mode-switch
authorPrashant Malani <pmalani@chromium.org>
Wed, 15 Jun 2022 17:20:17 +0000 (17:20 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Jun 2022 14:37:56 +0000 (16:37 +0200)
Loosen the typec_mux_match() requirements so that searches where an
alt mode is not specified, but the target mux device lists the
"mode-switch" property, return a success.

This is helpful in Type C port drivers which would like to get a pointer
to the mux switch associated with a Type C port, but don't want to
specify a particular alt mode.

Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: NĂ­colas F. R. A. Prado <nfraprado@collabora.com>
Tested-by: NĂ­colas F. R. A. Prado <nfraprado@collabora.com>
Link: https://lore.kernel.org/r/20220615172129.1314056-2-pmalani@chromium.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/mux.c

index fd55c2c..4643307 100644 (file)
@@ -281,9 +281,13 @@ static void *typec_mux_match(struct fwnode_handle *fwnode, const char *id,
        if (match)
                goto find_mux;
 
-       /* Accessory Mode muxes */
        if (!desc) {
-               match = fwnode_property_present(fwnode, "accessory");
+               /*
+                * Accessory Mode muxes & muxes which explicitly specify
+                * the required identifier can avoid SVID matching.
+                */
+               match = fwnode_property_present(fwnode, "accessory") ||
+                       fwnode_property_present(fwnode, id);
                if (match)
                        goto find_mux;
                return NULL;