hwrng: ba431 - use dev_err_probe after failed registration
authorMartin Kaiser <martin@kaiser.cx>
Thu, 13 Jul 2023 07:04:46 +0000 (09:04 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 22 Jul 2023 01:59:37 +0000 (13:59 +1200)
Use dev_err_probe to print the error message after a failed hwrng
registration.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/ba431-rng.c

index d2a9d16..9de7466 100644 (file)
@@ -190,10 +190,8 @@ static int ba431_trng_probe(struct platform_device *pdev)
        ba431->rng.read = ba431_trng_read;
 
        ret = devm_hwrng_register(&pdev->dev, &ba431->rng);
-       if (ret) {
-               dev_err(&pdev->dev, "BA431 registration failed (%d)\n", ret);
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(&pdev->dev, ret, "BA431 registration failed\n");
 
        dev_info(&pdev->dev, "BA431 TRNG registered\n");