mt76x0: usb: stop cal/mac workqueues at hw stop
authorLorenzo Bianconi <lorenzo.bianconi@redhat.com>
Wed, 3 Oct 2018 10:52:26 +0000 (12:52 +0200)
committerFelix Fietkau <nbd@nbd.name>
Fri, 5 Oct 2018 18:05:44 +0000 (20:05 +0200)
Stop mac and calibration work stopping the hw even if the
device has been removed

Fixes: b11e19694dc9 ("mt76x0: add ieee80211_ops ops pointer to
mt76x0_alloc_device signature")

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt76x0/usb.c

index dd437e7..57862ca 100644 (file)
@@ -86,14 +86,14 @@ static void mt76x0u_cleanup(struct mt76x0_dev *dev)
 
 static void mt76x0u_mac_stop(struct mt76x0_dev *dev)
 {
-       if (test_bit(MT76_REMOVED, &dev->mt76.state))
-               return;
-
        clear_bit(MT76_STATE_RUNNING, &dev->mt76.state);
        cancel_delayed_work_sync(&dev->cal_work);
        cancel_delayed_work_sync(&dev->mac_work);
        mt76u_stop_stat_wk(&dev->mt76);
 
+       if (test_bit(MT76_REMOVED, &dev->mt76.state))
+               return;
+
        mt76_clear(dev, MT_BEACON_TIME_CFG, MT_BEACON_TIME_CFG_TIMER_EN |
                   MT_BEACON_TIME_CFG_SYNC_MODE | MT_BEACON_TIME_CFG_TBTT_EN |
                   MT_BEACON_TIME_CFG_BEACON_TX);