projects
/
sdk
/
emulator
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
921a26f
)
x86/cpuid: Plug memory leak in cpudef_setfield()
author
Markus Armbruster
<armbru@redhat.com>
Tue, 8 Nov 2011 14:36:49 +0000
(15:36 +0100)
committer
Stefan Hajnoczi
<stefanha@linux.vnet.ibm.com>
Thu, 10 Nov 2011 12:29:50 +0000
(12:29 +0000)
To reproduce the leak, put two name options into the same [cpudef]
section of target-x86_64.conf.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
target-i386/cpuid.c
patch
|
blob
|
history
diff --git
a/target-i386/cpuid.c
b/target-i386/cpuid.c
index
352c390
..
99cff65
100644
(file)
--- a/
target-i386/cpuid.c
+++ b/
target-i386/cpuid.c
@@
-950,6
+950,7
@@
static int cpudef_setfield(const char *name, const char *str, void *opaque)
int err = 0;
if (!strcmp(name, "name")) {
+ g_free((void *)def->name);
def->name = g_strdup(str);
} else if (!strcmp(name, "model_id")) {
strncpy(def->model_id, str, sizeof (def->model_id));