projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
fe9f604
)
drm/vc4: Remove conflicting framebuffers before callind bind_all
author
Maxime Ripard
<maxime@cerno.tech>
Wed, 15 Dec 2021 09:51:16 +0000
(10:51 +0100)
committer
Dom Cobley
<popcornmix@gmail.com>
Mon, 21 Mar 2022 16:03:45 +0000
(16:03 +0000)
The bind hooks will modify their controller registers, so simplefb is
going to be unusable anyway. Let's avoid any transient state where it
could still be in the system but no longer functionnal.
Acked-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link:
https://patchwork.freedesktop.org/patch/msgid/20211215095117.176435-4-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_drv.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/vc4/vc4_drv.c
b/drivers/gpu/drm/vc4/vc4_drv.c
index
f6c16c5
..
3c0c7e7
100644
(file)
--- a/
drivers/gpu/drm/vc4/vc4_drv.c
+++ b/
drivers/gpu/drm/vc4/vc4_drv.c
@@
-253,15
+253,15
@@
static int vc4_drm_bind(struct device *dev)
if (ret)
return ret;
- ret =
component_bind_all(dev, drm
);
+ ret =
drm_aperture_remove_framebuffers(false, &vc4_drm_driver
);
if (ret)
return ret;
- ret =
vc4_plane_create_additional_planes(
drm);
+ ret =
component_bind_all(dev,
drm);
if (ret)
-
goto unbind_all
;
+
return ret
;
- ret =
drm_aperture_remove_framebuffers(false, &vc4_drm_driver
);
+ ret =
vc4_plane_create_additional_planes(drm
);
if (ret)
goto unbind_all;