video: fbdev: sh_mobile_lcdcfb: Fix ROP3 sysfs attribute parsing
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Sat, 14 Mar 2015 15:38:39 +0000 (17:38 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 20 Mar 2015 11:14:50 +0000 (13:14 +0200)
The ROP3 attribute is expressed as an integer in the 0-255 range. Remove
the wrong conversion to boolean when parsing it.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/sh_mobile_lcdcfb.c

index d3013cd..23421ec 100644 (file)
@@ -1461,7 +1461,7 @@ overlay_rop3_store(struct device *dev, struct device_attribute *attr,
        unsigned int rop3;
        char *endp;
 
-       rop3 = !!simple_strtoul(buf, &endp, 10);
+       rop3 = simple_strtoul(buf, &endp, 10);
        if (isspace(*endp))
                endp++;