drm/msm/mdp5: Add check for kzalloc
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Tue, 6 Dec 2022 07:48:19 +0000 (15:48 +0800)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tue, 24 Jan 2023 09:45:44 +0000 (11:45 +0200)
As kzalloc may fail and return NULL pointer,
it should be better to check the return value
in order to avoid the NULL pointer dereference.

Fixes: 1cff7440a86e ("drm/msm: Convert to using __drm_atomic_helper_crtc_reset() for reset.")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/514154/
Link: https://lore.kernel.org/r/20221206074819.18134-1-jiasheng@iscas.ac.cn
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c

index e86421c..86036dd 100644 (file)
@@ -1139,7 +1139,10 @@ static void mdp5_crtc_reset(struct drm_crtc *crtc)
        if (crtc->state)
                mdp5_crtc_destroy_state(crtc, crtc->state);
 
-       __drm_atomic_helper_crtc_reset(crtc, &mdp5_cstate->base);
+       if (mdp5_cstate)
+               __drm_atomic_helper_crtc_reset(crtc, &mdp5_cstate->base);
+       else
+               __drm_atomic_helper_crtc_reset(crtc, NULL);
 }
 
 static const struct drm_crtc_funcs mdp5_crtc_no_lm_cursor_funcs = {