iio: dac: ad5446: Don't set error code to voltage_uv
authorAxel Lin <axel.lin@ingics.com>
Tue, 18 Dec 2012 03:33:00 +0000 (03:33 +0000)
committerJonathan Cameron <jic23@kernel.org>
Thu, 27 Dec 2012 11:00:27 +0000 (11:00 +0000)
regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/dac/ad5446.c

index 3310cbb..ecb6395 100644 (file)
@@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name,
                if (ret)
                        goto error_put_reg;
 
-               voltage_uv = regulator_get_voltage(reg);
+               ret = regulator_get_voltage(reg);
+               if (ret < 0)
+                       goto error_disable_reg;
+
+               voltage_uv = ret;
        }
 
        indio_dev = iio_device_alloc(sizeof(*st));