Emit autoUpdater error directly as Error object
authorKevin Sawicki <kevinsawicki@gmail.com>
Fri, 21 Apr 2017 22:13:43 +0000 (15:13 -0700)
committerKevin Sawicki <kevinsawicki@gmail.com>
Mon, 24 Apr 2017 16:47:30 +0000 (09:47 -0700)
atom/browser/api/atom_api_auto_updater.cc

index ea30241..c23e488 100644 (file)
@@ -7,6 +7,7 @@
 #include "atom/browser/browser.h"
 #include "atom/browser/native_window.h"
 #include "atom/browser/window_list.h"
+#include "atom/common/api/event_emitter_caller.h"
 #include "atom/common/native_mate_converters/callback.h"
 #include "atom/common/node_includes.h"
 #include "base/time/time.h"
@@ -47,7 +48,9 @@ void AutoUpdater::OnError(const std::string& message) {
   v8::Locker locker(isolate());
   v8::HandleScope handle_scope(isolate());
   auto error = v8::Exception::Error(mate::StringToV8(isolate(), message));
-  EmitCustomEvent(
+  mate::EmitEvent(
+      isolate(),
+      GetWrapper(),
       "error",
       error->ToObject(isolate()->GetCurrentContext()).ToLocalChecked(),
       // Message is also emitted to keep compatibility with old code.