ALSA: azt3328: Fix assignment in if condition

PCI AZT3328 driver code contains a few assignments in if condition,
which is a bad coding style that may confuse readers and occasionally
lead to bugs.

This patch is merely for coding-style fixes, no functional changes.

Link: https://lore.kernel.org/r/20210608140540.17885-21-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/pci/azt3328.c b/sound/pci/azt3328.c
index 51dcf1b..4ee7ab4 100644 (file)
--- a/sound/pci/azt3328.c
+++ b/sound/pci/azt3328.c
@@ -1194,7 +1194,8 @@ snd_azf3328_mixer_new(struct snd_azf3328 *chip)
        sw = snd_azf3328_mixer_controls;
        for (idx = 0; idx < ARRAY_SIZE(snd_azf3328_mixer_controls);
                        ++idx, ++sw) {
-               if ((err = snd_ctl_add(chip->card, snd_ctl_new1(sw, chip))) < 0)
+               err = snd_ctl_add(chip->card, snd_ctl_new1(sw, chip));
+               if (err < 0)
                        return err;
        }
        snd_component_add(card, "AZF3328 mixer");