ceph: silence a checker warning in mdsc_show()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 9 May 2019 10:11:25 +0000 (13:11 +0300)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 8 Jul 2019 12:01:40 +0000 (14:01 +0200)
The problem is that if ceph_mdsc_build_path() fails then we set "path"
to NULL and the "pathlen" variable is uninitialized.  Then we call
ceph_mdsc_free_path(path, pathlen) to clean up.  Since "path" is NULL,
the function is a no-op but Smatch and UBSan still complain that
"pathlen" is uninitialized.

This patch doesn't change run time, it just silence the warnings.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/debugfs.c

index b3fc5fe..a14d646 100644 (file)
@@ -52,7 +52,7 @@ static int mdsc_show(struct seq_file *s, void *p)
        struct ceph_mds_client *mdsc = fsc->mdsc;
        struct ceph_mds_request *req;
        struct rb_node *rp;
-       int pathlen;
+       int pathlen = 0;
        u64 pathbase;
        char *path;