gpio: Remove VLA from xra1403 driver

The new challenge is to remove VLAs from the kernel
(see https://lkml.org/lkml/2018/3/7/621)

This patch replaces a VLA with an appropriate call to kmalloc_array.

Signed-off-by: Laura Abbott <labbott@redhat.com>
Reviewed-by: Nandor Han <nandor.han@ge.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c
index 0230e4b..8d4c8e9 100644 (file)
--- a/drivers/gpio/gpio-xra1403.c
+++ b/drivers/gpio/gpio-xra1403.c
@@ -126,11 +126,16 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 {
        int reg;
        struct xra1403 *xra = gpiochip_get_data(chip);
-       int value[xra1403_regmap_cfg.max_register];
+       int *value;
        int i;
        unsigned int gcr;
        unsigned int gsr;
 
+       value = kmalloc_array(xra1403_regmap_cfg.max_register, sizeof(*value),
+                               GFP_KERNEL);
+       if (!value)
+               return;
+
        seq_puts(s, "xra reg:");
        for (reg = 0; reg <= xra1403_regmap_cfg.max_register; reg++)
                seq_printf(s, " %2.2x", reg);
@@ -154,6 +159,7 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip)
                           (gcr & BIT(i)) ? "in" : "out",
                           (gsr & BIT(i)) ? "hi" : "lo");
        }
+       kfree(value);
 }
 #else
 #define xra1403_dbg_show NULL