net: dsa: mv88e6xxx: don't error out cmode set on missing lane
authorBaruch Siach <baruch.siach@siklu.com>
Mon, 28 Feb 2022 12:10:02 +0000 (14:10 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Mar 2022 06:33:37 +0000 (22:33 -0800)
When the given cmode has no serdes, mv88e6xxx_serdes_get_lane() returns
-NODEV. Earlier in the same function the code skips serdes handing in
this case. Do the same after cmode set.

Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
Link: https://lore.kernel.org/r/cd95cf3422ae8daf297a01fa9ec3931b203cdf45.1646050203.git.baruch@tkos.co.il
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/mv88e6xxx/port.c

index d08e3ec2b042ce138a080902127b71a4d4bae7a9..a58997f1fd69043d6b51691a031649fcf7d51d9b 100644 (file)
@@ -610,6 +610,8 @@ static int mv88e6xxx_port_set_cmode(struct mv88e6xxx_chip *chip, int port,
                chip->ports[port].cmode = cmode;
 
                lane = mv88e6xxx_serdes_get_lane(chip, port);
+               if (lane == -ENODEV)
+                       return 0;
                if (lane < 0)
                        return lane;