Add default label/accelerator to role menu items

diff --git a/lib/browser/api/menu-item-roles.js b/lib/browser/api/menu-item-roles.js
index 13484e5..f26e9c5 100644 (file)
--- a/lib/browser/api/menu-item-roles.js
+++ b/lib/browser/api/menu-item-roles.js
@@ -1,4 +1,4 @@
-module.exports = {
+const roles = {
   undo: {
     label: 'Undo',
     accelerator: 'CmdOrCtrl+Z',
@@ -63,3 +63,15 @@ module.exports = {
     method: 'toggleFullScreen'
   }
 }
+
+exports.getDefaultLabel = function (role) {
+  if (roles.hasOwnProperty(role)) {
+    return roles[role].label
+  } else {
+    return ''
+  }
+}
+
+exports.getDefaultAccelerator = function (role) {
+  if (roles.hasOwnProperty(role)) return roles[role].accelerator
+}

diff --git a/lib/browser/api/menu-item.js b/lib/browser/api/menu-item.js
index 264be81..ba98096 100644 (file)
--- a/lib/browser/api/menu-item.js
+++ b/lib/browser/api/menu-item.js
@@ -1,5 +1,7 @@
 'use strict'
 
+const roles = require('./menu-item-roles')
+
 let nextCommandId = 0
 
 // Maps role to methods of webContents
@@ -58,11 +60,11 @@ const MenuItem = function (options) {
 
   this.overrideReadOnlyProperty('type', 'normal')
   this.overrideReadOnlyProperty('role')
-  this.overrideReadOnlyProperty('accelerator')
+  this.overrideReadOnlyProperty('accelerator', roles.getDefaultAccelerator(this.role))
   this.overrideReadOnlyProperty('icon')
   this.overrideReadOnlyProperty('submenu')
 
-  this.overrideProperty('label', '')
+  this.overrideProperty('label', roles.getDefaultLabel(this.role))
   this.overrideProperty('sublabel', '')
   this.overrideProperty('enabled', true)
   this.overrideProperty('visible', true)