crash-manager: Fix error checking for pkgmgrinfo*() invocation

This commit fixes 'unchecked return value' as reported by coverity.

Change-Id: I8c31504fd03826862f85df5ff24d7752a12262e9

diff --git a/src/crash-manager/crash-manager.c b/src/crash-manager/crash-manager.c
index e2c6a0f..dee6e62 100644 (file)
--- a/src/crash-manager/crash-manager.c
+++ b/src/crash-manager/crash-manager.c
@@ -143,13 +143,11 @@ static int appinfo_get_appid_func(pkgmgrinfo_appinfo_h handle,
                void *user_data)
 {
        char *str = NULL;
-       int ret = PMINFO_R_ERROR;
 
-       pkgmgrinfo_appinfo_get_appid(handle, &str);
-       if (str) {
+       int ret = pkgmgrinfo_appinfo_get_appid(handle, &str);
+       if (ret == PMINFO_R_OK && str)
                (*(char **)user_data) = strdup(str);
-               ret = PMINFO_R_OK;
-       }
+
        return ret;
 }