nfsd: rq_lease_breaker cleanup
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 25 Sep 2020 14:12:39 +0000 (10:12 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 25 Sep 2020 22:02:03 +0000 (18:02 -0400)
Since only the v4 code cares about it, maybe it's better to leave
rq_lease_breaker out of the common dispatch code?

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c
fs/nfsd/nfssvc.c

index a59551e..4f39645 100644 (file)
@@ -4598,7 +4598,8 @@ static bool nfsd_breaker_owns_lease(struct file_lock *fl)
        if (!i_am_nfsd())
                return NULL;
        rqst = kthread_data(current);
-       if (!rqst->rq_lease_breaker)
+       /* Note rq_prog == NFS_ACL_PROGRAM is also possible: */
+       if (rqst->rq_prog != NFS_PROGRAM || rqst->rq_vers < 4)
                return NULL;
        clp = *(rqst->rq_lease_breaker);
        return dl->dl_stid.sc_client == clp;
index f7f6473..f6bc94c 100644 (file)
@@ -1016,7 +1016,6 @@ nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp)
                *statp = rpc_garbage_args;
                return 1;
        }
-       rqstp->rq_lease_breaker = NULL;
        /*
         * Give the xdr decoder a chance to change this if it wants
         * (necessary in the NFSv4.0 compound case)