net: warn about spaces in device names
authorMike Frysinger <vapier@gentoo.org>
Thu, 10 Jun 2010 02:10:48 +0000 (22:10 -0400)
committerBen Warren <biggerbadderben@gmail.com>
Mon, 12 Jul 2010 07:14:28 +0000 (00:14 -0700)
Some commands operate on eth device names (like 'mii'), but those cannot
be passed on the command line as one argument.  So detect devices like
these and warn about them so someone will fix it.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
net/eth.c

index 83d559c120406ab58213bf6ea46202b5a6870913..de6d5c6040ddeb2fc126779fed944e54834e84c6 100644 (file)
--- a/net/eth.c
+++ b/net/eth.c
@@ -234,6 +234,9 @@ int eth_initialize(bd_t *bis)
                                puts (" [PRIME]");
                        }
 
+                       if (strchr(dev->name, ' '))
+                               puts("\nWarning: eth device name has a space!\n");
+
                        eth_getenv_enetaddr_by_index(eth_number, env_enetaddr);
 
                        if (memcmp(env_enetaddr, "\0\0\0\0\0\0", 6)) {