crypto: x86/blowfish - remove redundant assignment to variable nytes
authorColin Ian King <colin.i.king@gmail.com>
Thu, 7 Jul 2022 08:05:46 +0000 (09:05 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 15 Jul 2022 08:43:22 +0000 (16:43 +0800)
Variable nbytes is being assigned a value that is never read, it is
being re-assigned in the next statement in the while-loop. The
assignment is redundant and can be removed.

Cleans up clang scan-build warnings, e.g.:
arch/x86/crypto/blowfish_glue.c:147:10: warning: Although the value
stored to 'nbytes' is used in the enclosing expression, the value
is never actually read from 'nbytes'

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/x86/crypto/blowfish_glue.c

index ba06322..019c64c 100644 (file)
@@ -144,7 +144,7 @@ static int cbc_encrypt(struct skcipher_request *req)
 
        err = skcipher_walk_virt(&walk, req, false);
 
-       while ((nbytes = walk.nbytes)) {
+       while (walk.nbytes) {
                nbytes = __cbc_encrypt(ctx, &walk);
                err = skcipher_walk_done(&walk, nbytes);
        }
@@ -225,7 +225,7 @@ static int cbc_decrypt(struct skcipher_request *req)
 
        err = skcipher_walk_virt(&walk, req, false);
 
-       while ((nbytes = walk.nbytes)) {
+       while (walk.nbytes) {
                nbytes = __cbc_decrypt(ctx, &walk);
                err = skcipher_walk_done(&walk, nbytes);
        }