media: imx: shut up a false positive warning
authorMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 7 Aug 2018 09:52:36 +0000 (05:52 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 7 Aug 2018 09:52:36 +0000 (05:52 -0400)
With imx, gcc produces a false positive warning:

drivers/staging/media/imx/imx-media-csi.c: In function 'csi_idmac_setup_channel':
drivers/staging/media/imx/imx-media-csi.c:457:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (passthrough) {
      ^
drivers/staging/media/imx/imx-media-csi.c:464:2: note: here
  default:
  ^~~~~~~

That's because the regex it uses for fall trough is not
good enough. So, rearrange the fall through comment in a way
that gcc will recognize.

Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/staging/media/imx/imx-media-csi.c

index 4647206..b7ffd23 100644 (file)
@@ -460,7 +460,8 @@ static int csi_idmac_setup_channel(struct csi_priv *priv)
                        passthrough_cycles = incc->cycles;
                        break;
                }
-               /* fallthrough for non-passthrough RGB565 (CSI-2 bus) */
+               /* for non-passthrough RGB565 (CSI-2 bus) */
+               /* Falls through */
        default:
                burst_size = (image.pix.width & 0xf) ? 8 : 16;
                passthrough_bits = 16;