Disable warnaserror for Windows (#31909)

Machines were updated to a newer VS 16.4 but CMake is 3.15.1 which is too old for VS validation of incremental native targets. We need 3.15.5 at least.

diff --git a/eng/pipelines/libraries/base-job.yml b/eng/pipelines/libraries/base-job.yml
index 9de712a..0a7389a 100644 (file)
--- a/eng/pipelines/libraries/base-job.yml
+++ b/eng/pipelines/libraries/base-job.yml
@@ -102,9 +102,8 @@ jobs:
         # Windows variables
         - ${{ if eq(parameters.osGroup, 'Windows_NT') }}:
           - _runtimeOSArg: /p:RuntimeOS=win10
-          - ${{ if eq(parameters.isOfficialBuild, 'true') }}:
-            # Remove when: https://github.com/dotnet/runtime/issues/31888 is fixed.
-            - _warnAsErrorArg: -warnAsError:0
+          # Remove when: https://github.com/dotnet/runtime/issues/31888 is fixed.
+          - _warnAsErrorArg: -warnAsError:0
 
         # Non-Windows variables
         - ${{ if ne(parameters.osGroup, 'Windows_NT') }}: