scsi: sd_zbc: Simplify zone full condition check
authorNiklas Cassel <niklas.cassel@wdc.com>
Wed, 1 Dec 2021 14:28:30 +0000 (14:28 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 3 Dec 2021 02:41:47 +0000 (21:41 -0500)
According to the ZBC (and ZAC) specification, a zone that has Zone Type set
to Conventional, must also have its Zone Condition set to "Not Write
Pointer".

Therefore, a conventional zone will never have Zone Condition set to
"Full", which means that we can omit the non-conventional prerequisite from
the zone full condition check.

Link: https://lore.kernel.org/r/20211201142821.64650-1-Niklas.Cassel@wdc.com
Suggested-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd_zbc.c

index ed06798..749c5e5 100644 (file)
@@ -62,8 +62,7 @@ static int sd_zbc_parse_report(struct scsi_disk *sdkp, u8 *buf,
        zone.capacity = zone.len;
        zone.start = logical_to_sectors(sdp, get_unaligned_be64(&buf[16]));
        zone.wp = logical_to_sectors(sdp, get_unaligned_be64(&buf[24]));
-       if (zone.type != ZBC_ZONE_TYPE_CONV &&
-           zone.cond == ZBC_ZONE_COND_FULL)
+       if (zone.cond == ZBC_ZONE_COND_FULL)
                zone.wp = zone.start + zone.len;
 
        ret = cb(&zone, idx, data);