[NUI][AT-SPI] Add IAtspiValue.AccessibilityGetValueText()

This API allows the application to provide the Screen Reader with a formatted
string value rather than the default, floating-point one. This in turn, allows
to customize in detail how e.g. slider values are read.

diff --git a/src/Tizen.NUI.Components/Controls/Pagination.cs b/src/Tizen.NUI.Components/Controls/Pagination.cs
index 569dc15cbf2980beaffb740541d99a55fceadf2f..992f527bd41e779cd11686f7f8ba6c5135343352 100755 (executable)
--- a/src/Tizen.NUI.Components/Controls/Pagination.cs
+++ b/src/Tizen.NUI.Components/Controls/Pagination.cs
@@ -470,6 +470,15 @@ namespace Tizen.NUI.Components
             return (double)SelectedIndex;
         }
 
+        /// <summary>
+        /// Formatted current value.
+        /// </summary>
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        string IAtspiValue.AccessibilityGetValueText()
+        {
+            return $"{SelectedIndex}";
+        }
+
         /// <summary>
         /// Maximum value.
         /// </summary>

diff --git a/src/Tizen.NUI.Components/Controls/Progress.cs b/src/Tizen.NUI.Components/Controls/Progress.cs
index 07561fa1132dca13cc3384ee8e622f81a430316e..70e88e0b8d18809e82955901e6b0150375fa1551 100755 (executable)
--- a/src/Tizen.NUI.Components/Controls/Progress.cs
+++ b/src/Tizen.NUI.Components/Controls/Progress.cs
@@ -545,6 +545,15 @@ namespace Tizen.NUI.Components
             }
         }
 
+        /// <summary>
+        /// Formatted current value.
+        /// </summary>
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        string IAtspiValue.AccessibilityGetValueText()
+        {
+            return (this as IAtspiValue).AccessibilityGetCurrent().ToString();
+        }
+
         [EditorBrowsable(EditorBrowsableState.Never)]
         bool IAtspiValue.AccessibilitySetCurrent(double value)
         {

diff --git a/src/Tizen.NUI.Components/Controls/Slider.cs b/src/Tizen.NUI.Components/Controls/Slider.cs
index cfc3b512f9aa6061feff84824f102e4ffe9db81e..5b21df452aa6e4915461d3f26a947f383c5c9eaa 100755 (executable)
--- a/src/Tizen.NUI.Components/Controls/Slider.cs
+++ b/src/Tizen.NUI.Components/Controls/Slider.cs
@@ -1608,6 +1608,15 @@ namespace Tizen.NUI.Components
             return (double)CurrentValue;
         }
 
+        /// <summary>
+        /// Formatted current value.
+        /// </summary>
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        string IAtspiValue.AccessibilityGetValueText()
+        {
+            return $"{CurrentValue}";
+        }
+
         /// <summary>
         /// Gets maximum value for Accessibility.
         /// </summary>

diff --git a/src/Tizen.NUI/src/internal/Interop/Interop.ControlDevel.cs b/src/Tizen.NUI/src/internal/Interop/Interop.ControlDevel.cs
index 8aadebec0391d23ceb9c0473b2c35a6fb882a158..3ed46a01566a8fb6015337644827b427d81cb650 100755 (executable)
--- a/src/Tizen.NUI/src/internal/Interop/Interop.ControlDevel.cs
+++ b/src/Tizen.NUI/src/internal/Interop/Interop.ControlDevel.cs
@@ -383,6 +383,11 @@ namespace Tizen.NUI
                 public delegate void AccessibilityGetAttributes(IntPtr self, AccessibilityGetAttributesCallback callback, IntPtr userData);
                 [EditorBrowsable(EditorBrowsableState.Never)]
                 public AccessibilityGetAttributes GetAttributes; // 37
+
+                [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
+                public delegate IntPtr AccessibilityGetValueText(IntPtr self);
+                [EditorBrowsable(EditorBrowsableState.Never)]
+                public AccessibilityGetValueText GetValueText; // 38
             }
 
             [DllImport(NDalicPINVOKE.Lib, EntryPoint = "CSharp_Dali_Accessibility_DuplicateString")]

diff --git a/src/Tizen.NUI/src/public/Accessibility/IAtspiValue.cs b/src/Tizen.NUI/src/public/Accessibility/IAtspiValue.cs
index 338889fb2fc4de9810d8f6a3d078a22987097684..a6fecb75fe91f50ed4ec5aefeb60315c45414eb3 100644 (file)
--- a/src/Tizen.NUI/src/public/Accessibility/IAtspiValue.cs
+++ b/src/Tizen.NUI/src/public/Accessibility/IAtspiValue.cs
@@ -26,9 +26,32 @@ namespace Tizen.NUI.Accessibility
         [EditorBrowsable(EditorBrowsableState.Never)]
         double AccessibilityGetMinimum();
 
+        /// <summary>
+        /// Gets the current numeric value.
+        /// </summary>
+        /// <remarks>
+        /// The application may set the "value_format" attribute to one of the
+        /// following values in order to customize what is read by the Screen Reader:
+        /// 1. "percent" (the default) - AccessibilityGetCurrent() normalized as
+        ///    a percentage of the range [AccessibilityGetMinimum(), AccessibilityGetMaximum()],
+        /// 2. "number" - AccessibilityGetCurrent() verbatim,
+        /// 3. "text" - AccessibilityGetValueText() is used instead of AccessibilityGetCurrent()
+        /// </remarks>
         [EditorBrowsable(EditorBrowsableState.Never)]
         double AccessibilityGetCurrent();
 
+        /// <summary>
+        /// Gets the formatted current value.
+        /// </summary>
+        /// <remarks>
+        /// This does not have to be AccessibilityGetCurrent() formatted in any
+        /// particular way, i.e. it may be an arbitrary string, e.g. "small font size"
+        /// for the numeric value 10.0. The return value of this method is only
+        /// used if the "value_format" attribute is "text".
+        /// </remarks>
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        string AccessibilityGetValueText();
+
         [EditorBrowsable(EditorBrowsableState.Never)]
         double AccessibilityGetMaximum();
 

diff --git a/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibility.cs b/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibility.cs
index dbc41bd588019942621aadcf9abfa44a1fa23de4..efae6ea93e3d030620007a9f9e7c2b0444225141 100755 (executable)
--- a/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibility.cs
+++ b/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibility.cs
@@ -59,7 +59,7 @@ namespace Tizen.NUI.BaseComponents
         /// Dictionary of accessibility attributes (key-value pairs of strings).
         /// </summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
-        protected Dictionary<string, string> AccessibilityAttributes { get; } = new Dictionary<string, string>();
+        public Dictionary<string, string> AccessibilityAttributes { get; } = new Dictionary<string, string>();
 
         ///////////////////////////////////////////////////////////////////
         // ************************** Highlight ************************ //

diff --git a/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibilityEvent.cs b/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibilityEvent.cs
index 89ca54e1cb9ef434d92e841760bef217b4a86353..2727ef4cd1bd0e817dbafc784dbbfd129d55274e 100755 (executable)
--- a/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibilityEvent.cs
+++ b/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibilityEvent.cs
@@ -420,6 +420,18 @@ namespace Tizen.NUI.BaseComponents
             return ret;
         }
 
+        // AccessibilityValueTextRequested
+
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        public class AccessibilityValueTextRequestedEventArgs : EventArgs
+        {
+            [EditorBrowsable(EditorBrowsableState.Never)]
+            public string Text { get; set; }
+        }
+
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        public event EventHandler<AccessibilityValueTextRequestedEventArgs> AccessibilityValueTextRequested;
+
         ///////////////////////////////////////////////////////////////////
         // **************** AccessibilityActivatedSignal **************** //
         ///////////////////////////////////////////////////////////////////

diff --git a/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibilityWrappers.cs b/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibilityWrappers.cs
index 07bc576fc9715cc9ebfc15a86d031c9c1f33a2bd..5874cd1f922dfd0714ff0bb9a20aeb7258dbc89e 100644 (file)
--- a/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibilityWrappers.cs
+++ b/src/Tizen.NUI/src/public/BaseComponents/ViewAccessibilityWrappers.cs
@@ -400,6 +400,7 @@ namespace Tizen.NUI.BaseComponents
             ad.GetMaximum          = AccessibilityGetMaximumWrapper;
             ad.GetMinimum          = AccessibilityGetMinimumWrapper;
             ad.GetMinimumIncrement = AccessibilityGetMinimumIncrementWrapper;
+            ad.GetValueText        = AccessibilityGetValueTextWrapper;
             ad.SetCurrent          = AccessibilitySetCurrentWrapper;
         }
 
@@ -423,6 +424,33 @@ namespace Tizen.NUI.BaseComponents
             return GetInterfaceFromRefObject<IAtspiValue>(self).AccessibilityGetMinimumIncrement();
         }
 
+        private static IntPtr AccessibilityGetValueTextWrapper(IntPtr self)
+        {
+            var view = GetViewFromRefObject(self);
+            var value = GetInterfaceFromRefObject<IAtspiValue>(self);
+            string text;
+
+            // Mimic the behaviour of the pairs AccessibilityNameRequested & AccessibilityGetName(),
+            // and AccessibilityDescriptionRequested & AccessibilityGetDescription(),
+            // i.e. a higher-priority Accessibility[…]Requested event for application developers,
+            // and a lower-priority AccessibilityGet[…]() virtual method for component developers.
+            // The difference is that event-or-virtual-method dispatching is done in C++ for
+            // Name and Description, and here in this wrapper method for ValueText (because there
+            // is no signal for ValueText in DALi.)
+            if (view.AccessibilityValueTextRequested?.GetInvocationList().Length > 0)
+            {
+                var args = new AccessibilityValueTextRequestedEventArgs();
+                view.AccessibilityValueTextRequested.Invoke(view, args);
+                text = args.Text;
+            }
+            else
+            {
+                text = value.AccessibilityGetValueText();
+            }
+
+            return DuplicateString(text);
+        }
+
         private static bool AccessibilitySetCurrentWrapper(IntPtr self, double value)
         {
             return GetInterfaceFromRefObject<IAtspiValue>(self).AccessibilitySetCurrent(value);