misc: tps6594: Remove redundant dev_err_probe() for platform_get_irq_byname()
authorRuan Jinjie <ruanjinjie@huawei.com>
Mon, 7 Aug 2023 09:30:10 +0000 (17:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Aug 2023 10:58:40 +0000 (12:58 +0200)
There is no need to call the dev_err_probe() function directly to print
a custom message when handling an error from platform_get_irq_byname()
function as it is going to display an appropriate error message
in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230807093010.2112302-1-ruanjinjie@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/tps6594-esm.c
drivers/misc/tps6594-pfsm.c

index a32da1c..e8d12e7 100644 (file)
@@ -39,8 +39,7 @@ static int tps6594_esm_probe(struct platform_device *pdev)
        for (i = 0 ; i < pdev->num_resources ; i++) {
                irq = platform_get_irq_byname(pdev, pdev->resource[i].name);
                if (irq < 0)
-                       return dev_err_probe(dev, irq, "Failed to get %s irq\n",
-                                            pdev->resource[i].name);
+                       return irq;
 
                ret = devm_request_threaded_irq(dev, irq, NULL,
                                                tps6594_esm_isr, IRQF_ONESHOT,
index 0e24f8d..88dcac8 100644 (file)
@@ -266,8 +266,7 @@ static int tps6594_pfsm_probe(struct platform_device *pdev)
        for (i = 0 ; i < pdev->num_resources ; i++) {
                irq = platform_get_irq_byname(pdev, pdev->resource[i].name);
                if (irq < 0)
-                       return dev_err_probe(dev, irq, "Failed to get %s irq\n",
-                                            pdev->resource[i].name);
+                       return irq;
 
                ret = devm_request_threaded_irq(dev, irq, NULL,
                                                tps6594_pfsm_isr, IRQF_ONESHOT,