selftests/memory-hotplug: Add checking after online or offline
authorZhao Gongyi <zhaogongyi@huawei.com>
Fri, 30 Sep 2022 06:35:24 +0000 (14:35 +0800)
committerShuah Khan <skhan@linuxfoundation.org>
Fri, 7 Oct 2022 16:31:58 +0000 (10:31 -0600)
Add checking for online_memory_expect_success()/
offline_memory_expect_success()/offline_memory_expect_fail(), or
the test would exit 0 although the functions return 1.

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/memory-hotplug/mem-on-off-test.sh

index 46a97f3..1d87611 100755 (executable)
@@ -266,7 +266,9 @@ done
 #
 echo $error > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error
 for memory in `hotpluggable_offline_memory`; do
-       online_memory_expect_fail $memory
+       if ! online_memory_expect_fail $memory; then
+               retval=1
+       fi
 done
 
 #
@@ -274,7 +276,9 @@ done
 #
 echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error
 for memory in `hotpluggable_offline_memory`; do
-       online_memory_expect_success $memory
+       if ! online_memory_expect_success $memory; then
+               retval=1
+       fi
 done
 
 #
@@ -283,7 +287,9 @@ done
 echo $error > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error
 for memory in `hotpluggable_online_memory`; do
        if [ $((RANDOM % 100)) -lt $ratio ]; then
-               offline_memory_expect_fail $memory
+               if ! offline_memory_expect_fail $memory; then
+                       retval=1
+               fi
        fi
 done