scsi: arcmsr: clean up clang warning on extraneous parentheses
authorColin Ian King <colin.king@canonical.com>
Sun, 30 Sep 2018 23:03:07 +0000 (00:03 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 24 Nov 2019 07:20:59 +0000 (08:20 +0100)
[ Upstream commit ca2ade24157693b4e533ccec69df00ef719d4aad ]

There are extraneous parantheses that are causing clang to produce a
warning so remove these.

Clean up 3 clang warnings:
equality comparison with extraneous parentheses [-Wparentheses-equality]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ching Huang <ching2048@areca.com.tw>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/arcmsr/arcmsr_hba.c

index 12316ef..c75d469 100644 (file)
@@ -4135,9 +4135,9 @@ static void arcmsr_hardware_reset(struct AdapterControlBlock *acb)
                pci_read_config_byte(acb->pdev, i, &value[i]);
        }
        /* hardware reset signal */
-       if ((acb->dev_id == 0x1680)) {
+       if (acb->dev_id == 0x1680) {
                writel(ARCMSR_ARC1680_BUS_RESET, &pmuA->reserved1[0]);
-       } else if ((acb->dev_id == 0x1880)) {
+       } else if (acb->dev_id == 0x1880) {
                do {
                        count++;
                        writel(0xF, &pmuC->write_sequence);
@@ -4161,7 +4161,7 @@ static void arcmsr_hardware_reset(struct AdapterControlBlock *acb)
                } while (((readl(&pmuE->host_diagnostic_3xxx) &
                        ARCMSR_ARC1884_DiagWrite_ENABLE) == 0) && (count < 5));
                writel(ARCMSR_ARC188X_RESET_ADAPTER, &pmuE->host_diagnostic_3xxx);
-       } else if ((acb->dev_id == 0x1214)) {
+       } else if (acb->dev_id == 0x1214) {
                writel(0x20, pmuD->reset_request);
        } else {
                pci_write_config_byte(acb->pdev, 0x84, 0x20);