scsi: megaraid: Fix ifnullfree.cocci warnings
authorkernel test robot <lkp@intel.com>
Fri, 11 Dec 2020 10:16:15 +0000 (11:16 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 23 Jan 2021 03:24:44 +0000 (22:24 -0500)
NULL check before vfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2012111113060.2669@hadrien
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_sas_fusion.c

index fd60728..38fc946 100644 (file)
@@ -3920,8 +3920,7 @@ megasas_free_host_crash_buffer(struct megasas_instance *instance)
 {
        unsigned int i;
        for (i = 0; i < instance->drv_buf_alloc; i++) {
-               if (instance->crash_buf[i])
-                       vfree(instance->crash_buf[i]);
+               vfree(instance->crash_buf[i]);
        }
        instance->drv_buf_index = 0;
        instance->drv_buf_alloc = 0;