Inline YieldProcessor on Linux (dotnet/coreclr#12058)

Commit migrated from https://github.com/dotnet/coreclr/commit/be28ab1ad1159f784254e4a77e2fe9cd99dc34c8

diff --git a/src/coreclr/src/dlls/mscordac/mscordac_unixexports.src b/src/coreclr/src/dlls/mscordac/mscordac_unixexports.src
index b467ece..7bb1c87 100644 (file)
--- a/src/coreclr/src/dlls/mscordac/mscordac_unixexports.src
+++ b/src/coreclr/src/dlls/mscordac/mscordac_unixexports.src
@@ -175,7 +175,6 @@ WaitForSingleObject
 WaitForSingleObjectEx
 WideCharToMultiByte
 WriteFile
-YieldProcessor
 
 nativeStringResourceTable_mscorrc_debug
 _ZN25NativeExceptionHolderBase4PushEv

diff --git a/src/coreclr/src/pal/inc/pal.h b/src/coreclr/src/pal/inc/pal.h
index 0f470d9..2d703e8 100644 (file)
--- a/src/coreclr/src/pal/inc/pal.h
+++ b/src/coreclr/src/pal/inc/pal.h
@@ -4560,11 +4560,22 @@ MemoryBarrier(
     __sync_synchronize();
 }
 
+EXTERN_C
 PALIMPORT
+inline
 VOID
 PALAPI
 YieldProcessor(
-    VOID);
+    VOID)
+{
+#if defined(_X86_) || defined(_AMD64_)
+    __asm__ __volatile__(
+        "rep\n"
+        "nop");
+#else
+    return;
+#endif
+}
 
 PALIMPORT
 DWORD

diff --git a/src/coreclr/src/pal/src/arch/amd64/processor.cpp b/src/coreclr/src/pal/src/arch/amd64/processor.cpp
index 0ab7992..a520111 100644 (file)
--- a/src/coreclr/src/pal/src/arch/amd64/processor.cpp
+++ b/src/coreclr/src/pal/src/arch/amd64/processor.cpp
@@ -23,27 +23,6 @@ Abstract:
 
 /*++
 Function:
-YieldProcessor
-
-The YieldProcessor function signals to the processor to give resources
-to threads that are waiting for them. This macro is only effective on
-processors that support technology allowing multiple threads running
-on a single processor, such as Intel's Hyper-Threading technology.
-
---*/
-void
-PALAPI
-YieldProcessor(
-    VOID)
-{
-    __asm__ __volatile__ (
-        "rep\n"
-        "nop"
-    );
-}
-
-/*++
-Function:
 XmmYmmStateSupport
 
 Check if OS has enabled both XMM and YMM state support

diff --git a/src/coreclr/src/pal/src/arch/arm/processor.cpp b/src/coreclr/src/pal/src/arch/arm/processor.cpp
index f41caff..7993212 100644 (file)
--- a/src/coreclr/src/pal/src/arch/arm/processor.cpp
+++ b/src/coreclr/src/pal/src/arch/arm/processor.cpp
@@ -20,23 +20,3 @@ Abstract:
 --*/
 
 #include "pal/palinternal.h"
-
-/*++
-Function:
-YieldProcessor
-
-The YieldProcessor function signals to the processor to give resources
-to threads that are waiting for them. This macro is only effective on
-processors that support technology allowing multiple threads running
-on a single processor, such as Intel's Hyper-Threading technology.
-
---*/
-void
-PALAPI
-YieldProcessor(
-    VOID)
-{
-       // Pretty sure ARM has no useful function here?
-    return;
-}
-

diff --git a/src/coreclr/src/pal/src/arch/arm64/processor.cpp b/src/coreclr/src/pal/src/arch/arm64/processor.cpp
index 6c7851a..4c47210 100644 (file)
--- a/src/coreclr/src/pal/src/arch/arm64/processor.cpp
+++ b/src/coreclr/src/pal/src/arch/arm64/processor.cpp
@@ -20,22 +20,3 @@ Abstract:
 --*/
 
 #include "pal/palinternal.h"
-
-/*++
-Function:
-YieldProcessor
-
-The YieldProcessor function signals to the processor to give resources
-to threads that are waiting for them. This macro is only effective on
-processors that support technology allowing multiple threads running
-on a single processor, such as Intel's Hyper-Threading technology.
-
---*/
-void
-PALAPI
-YieldProcessor(
-    VOID)
-{
-    return;
-}
-

diff --git a/src/coreclr/src/pal/src/arch/i386/processor.cpp b/src/coreclr/src/pal/src/arch/i386/processor.cpp
index 4fd3a4a..e1c8de1 100644 (file)
--- a/src/coreclr/src/pal/src/arch/i386/processor.cpp
+++ b/src/coreclr/src/pal/src/arch/i386/processor.cpp
@@ -20,25 +20,3 @@ Abstract:
 --*/
 
 #include "pal/palinternal.h"
-
-/*++
-Function:
-YieldProcessor
-
-The YieldProcessor function signals to the processor to give resources
-to threads that are waiting for them. This macro is only effective on
-processors that support technology allowing multiple threads running
-on a single processor, such as Intel's Hyper-Threading technology.
-
---*/
-void
-PALAPI
-YieldProcessor(
-    VOID)
-{
-    __asm__ __volatile__ (
-        "rep\n"
-        "nop"
-    );
-}
-