[flang] bugfixing and review comments

Original-commit: flang-compiler/f18@6df4a52d6bb2575c3eb4726b633a0cf98da0d298
Reviewed-on: https://github.com/flang-compiler/f18/pull/225
Tree-same-pre-rewrite: false

diff --git a/flang/documentation/C++style.md b/flang/documentation/C++style.md
index 1e9e975..768f44b 100644 (file)
--- a/flang/documentation/C++style.md
+++ b/flang/documentation/C++style.md
@@ -203,7 +203,7 @@ A feature matrix:
 | pointer | nullable | default null | owning | reassignable | copyable | undefined type ok? |
 | ------- | -------- | ------------ | ------ | ------------ | -------- | ------------------ |
 | `*p` | yes | no | no | yes | shallowly | yes |
-| `&r` | no | n/a | no | no | shallowly | no |
+| `&r` | no | n/a | no | no | shallowly | yes |
 | `unique_ptr<>` | yes | yes | yes | yes | no | no |
 | `shared_ptr<>` | yes | yes | yes | yes | shallowly | no |
 | `OwningPointer<>` | yes | yes | yes | yes | no | yes |

diff --git a/flang/lib/parser/characters.h b/flang/lib/parser/characters.h
index 7a0f41d..362ccc4 100644 (file)
--- a/flang/lib/parser/characters.h
+++ b/flang/lib/parser/characters.h
@@ -103,7 +103,7 @@ inline constexpr char HexadecimalDigitValue(char ch) {
 
 inline constexpr std::optional<char> BackslashEscapeValue(char ch) {
   switch (ch) {
-  case 'a': return {'\a'};
+  // case 'a': return {'\a'};  // pgf90 has no \a
   case 'b': return {'\b'};
   case 'f': return {'\f'};
   case 'n': return {'\n'};
@@ -119,7 +119,7 @@ inline constexpr std::optional<char> BackslashEscapeValue(char ch) {
 
 inline constexpr std::optional<char> BackslashEscapeChar(char ch) {
   switch (ch) {
-  case '\a': return {'a'};
+  // case '\a': return {'a'};  // pgf90 has no \a
   case '\b': return {'b'};
   case '\f': return {'f'};
   case '\n': return {'n'};