projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7e9298f
)
ext4: fix error code in ext4_commit_super
author
Fengnan Chang
<changfengnan@vivo.com>
Fri, 2 Apr 2021 10:16:31 +0000
(18:16 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Tue, 11 May 2021 12:47:37 +0000
(14:47 +0200)
commit
f88f1466e2a2e5ca17dfada436d3efa1b03a3972
upstream.
We should set the error code when ext4_commit_super check argument failed.
Found in code review.
Fixes:
c4be0c1dc4cdc
("filesystem freeze: add error handling of write_super_lockfs/unlockfs").
Cc: stable@kernel.org
Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link:
https://lore.kernel.org/r/20210402101631.561-1-changfengnan@vivo.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/super.c
patch
|
blob
|
history
diff --git
a/fs/ext4/super.c
b/fs/ext4/super.c
index
8467be0
..
c7f5b66
100644
(file)
--- a/
fs/ext4/super.c
+++ b/
fs/ext4/super.c
@@
-5489,8
+5489,10
@@
static int ext4_commit_super(struct super_block *sb, int sync)
struct buffer_head *sbh = EXT4_SB(sb)->s_sbh;
int error = 0;
- if (!sbh || block_device_ejected(sb))
- return error;
+ if (!sbh)
+ return -EINVAL;
+ if (block_device_ejected(sb))
+ return -ENODEV;
/*
* If the file system is mounted read-only, don't update the