mfd: t7l66xb: Drop platform disable callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 30 May 2022 19:24:28 +0000 (21:24 +0200)
committerLee Jones <lee@kernel.org>
Tue, 19 Jul 2022 09:54:38 +0000 (10:54 +0100)
None of the in-tree instantiations of struct t7l66xb_platform_data
provides a disable callback. So better don't dereference this function
pointer unconditionally. As there is no user, drop it completely instead
of calling it conditional.

This is a preparation for making platform remove callbacks return void.

Fixes: 1f192015ca5b ("mfd: driver for the T7L66XB TMIO SoC")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220530192430.2108217-3-u.kleine-koenig@pengutronix.de
drivers/mfd/t7l66xb.c
include/linux/mfd/t7l66xb.h

index 5369c67..663ffd4 100644 (file)
@@ -397,11 +397,8 @@ err_noirq:
 
 static int t7l66xb_remove(struct platform_device *dev)
 {
-       struct t7l66xb_platform_data *pdata = dev_get_platdata(&dev->dev);
        struct t7l66xb *t7l66xb = platform_get_drvdata(dev);
-       int ret;
 
-       ret = pdata->disable(dev);
        clk_disable_unprepare(t7l66xb->clk48m);
        clk_put(t7l66xb->clk48m);
        clk_disable_unprepare(t7l66xb->clk32k);
@@ -412,8 +409,7 @@ static int t7l66xb_remove(struct platform_device *dev)
        mfd_remove_devices(&dev->dev);
        kfree(t7l66xb);
 
-       return ret;
-
+       return 0;
 }
 
 static struct platform_driver t7l66xb_platform_driver = {
index 69632c1..ae3e7a5 100644 (file)
@@ -12,7 +12,6 @@
 
 struct t7l66xb_platform_data {
        int (*enable)(struct platform_device *dev);
-       int (*disable)(struct platform_device *dev);
        int (*suspend)(struct platform_device *dev);
        int (*resume)(struct platform_device *dev);