Fix a potential race in operation_idle_cb().

diff --git a/camel/camel-operation.c b/camel/camel-operation.c
index 028ee29..e03702f 100644 (file)
--- a/camel/camel-operation.c
+++ b/camel/camel-operation.c
@@ -120,6 +120,11 @@ operation_idle_cb (CamelOperation *operation)
        gchar *msg;
        gint pc;
 
+       /* Keep the operation alive until we emit the signal,
+        * otherwise it might be finalized between unlocking
+        * the mutex and emitting the signal. */
+       g_object_ref (operation);
+
        LOCK ();
 
        msg = operation->priv->status_msg;
@@ -136,6 +141,8 @@ operation_idle_cb (CamelOperation *operation)
                g_free (msg);
        }
 
+       g_object_unref (operation);
+
        return FALSE;
 }