platform/x86: asus-wmi: Drop indentation level by inverting conditionals
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 16 Aug 2019 11:07:17 +0000 (14:07 +0300)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 16 Aug 2019 11:20:35 +0000 (14:20 +0300)
We have extra indentation level where it can be avoided by changing conditional
to the inverted one.

Do it here for three such locations in the driver.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/asus-wmi.c

index 42dc2db..d538b8c 100644 (file)
@@ -445,15 +445,14 @@ static int kbd_led_read(struct asus_wmi *asus, int *level, int *env)
        if (retval == 0x8000)
                retval = 0;
 
-       if (retval >= 0) {
-               if (level)
-                       *level = retval & 0x7F;
-               if (env)
-                       *env = (retval >> 8) & 0x7F;
-               retval = 0;
-       }
+       if (retval < 0)
+               return retval;
 
-       return retval;
+       if (level)
+               *level = retval & 0x7F;
+       if (env)
+               *env = (retval >> 8) & 0x7F;
+       return 0;
 }
 
 static void do_kbd_led_set(struct led_classdev *led_cdev, int value)
@@ -767,16 +766,14 @@ static int asus_register_rfkill_notifier(struct asus_wmi *asus, char *node)
        acpi_handle handle;
 
        status = acpi_get_handle(NULL, node, &handle);
-
-       if (ACPI_SUCCESS(status)) {
-               status = acpi_install_notify_handler(handle,
-                                                    ACPI_SYSTEM_NOTIFY,
-                                                    asus_rfkill_notify, asus);
-               if (ACPI_FAILURE(status))
-                       pr_warn("Failed to register notify on %s\n", node);
-       } else
+       if (ACPI_FAILURE(status))
                return -ENODEV;
 
+       status = acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
+                                            asus_rfkill_notify, asus);
+       if (ACPI_FAILURE(status))
+               pr_warn("Failed to register notify on %s\n", node);
+
        return 0;
 }
 
@@ -786,15 +783,13 @@ static void asus_unregister_rfkill_notifier(struct asus_wmi *asus, char *node)
        acpi_handle handle;
 
        status = acpi_get_handle(NULL, node, &handle);
+       if (ACPI_FAILURE(status))
+               return;
 
-       if (ACPI_SUCCESS(status)) {
-               status = acpi_remove_notify_handler(handle,
-                                                   ACPI_SYSTEM_NOTIFY,
-                                                   asus_rfkill_notify);
-               if (ACPI_FAILURE(status))
-                       pr_err("Error removing rfkill notify handler %s\n",
-                              node);
-       }
+       status = acpi_remove_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
+                                           asus_rfkill_notify);
+       if (ACPI_FAILURE(status))
+               pr_err("Error removing rfkill notify handler %s\n", node);
 }
 
 static int asus_get_adapter_status(struct hotplug_slot *hotplug_slot,