staging: r8188eu: set two more state variables
authorMartin Kaiser <martin@kaiser.cx>
Sat, 15 Oct 2022 15:11:14 +0000 (17:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 Oct 2022 15:41:42 +0000 (17:41 +0200)
Set two more state variables in the blink worker when scan blinking and
tx/rx blinking are finished.

bLedBlinkInProgress is true during tx/rx blinking, bLedScanBlinkInProgress
is true during scan blinking. If we doing neither of the two, we may
safely set both variables to false.

This change makes the scan and tx/rx cases almost identical, we are now
ready to summarize the two cases.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20221015151115.232095-10-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_led.c

index 2dbd7b5..f8bd183 100644 (file)
@@ -90,6 +90,7 @@ static void blink_work(struct work_struct *work)
                                pLed->CurrLedState = LED_BLINK_SLOWLY;
                                schedule_delayed_work(&pLed->blink_work, LED_BLINK_NO_LINK_INTVL);
                        }
+                       pLed->bLedBlinkInProgress = false;
                        pLed->bLedScanBlinkInProgress = false;
                } else {
                        schedule_delayed_work(&pLed->blink_work, LED_BLINK_SCAN_INTVL);
@@ -106,6 +107,7 @@ static void blink_work(struct work_struct *work)
                                schedule_delayed_work(&pLed->blink_work, LED_BLINK_NO_LINK_INTVL);
                        }
                        pLed->bLedBlinkInProgress = false;
+                       pLed->bLedScanBlinkInProgress = false;
                } else {
                        schedule_delayed_work(&pLed->blink_work, LED_BLINK_FASTER_INTVL);
                }