Revert "Expose GetAddressingBits() in the Process API."

This reverts commit 7504dd5e00f514628614db8ee07514c73220e597.

In newer review feedback it was pointed out that there is a better API for this in Process::GetCodeAddressMask().

diff --git a/lldb/include/lldb/Target/Process.h b/lldb/include/lldb/Target/Process.h
index 7c4302342988b51eadf3604551ce98f5aa9d9d23..7d8fbb7797d897c3a38338f20c9e7db7d47c61e3 100644 (file)
--- a/lldb/include/lldb/Target/Process.h
+++ b/lldb/include/lldb/Target/Process.h
@@ -699,9 +699,6 @@ public:
   /// Get the system architecture for this process.
   virtual ArchSpec GetSystemArchitecture() { return {}; }
 
-  /// Return the number of bits in a vmaddr that are used by valid addresses.
-  virtual llvm::Optional<uint32_t> GetAddressingBits() { return {}; }
-
   /// Get the system runtime plug-in for this process.
   ///
   /// \return

diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index 12747321a2932c90d046bb4d7465b8f9b8df27fc..2e652e11ea1105d6c28841e1baa4cd9e2cab6a74 100644 (file)
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -212,10 +212,6 @@ ArchSpec ProcessGDBRemote::GetSystemArchitecture() {
   return m_gdb_comm.GetHostArchitecture();
 }
 
-llvm::Optional<uint32_t> ProcessGDBRemote::GetAddressingBits() {
-  return m_gdb_comm.GetAddressingBits();
-}
-
 bool ProcessGDBRemote::CanDebug(lldb::TargetSP target_sp,
                                 bool plugin_specified_by_name) {
   if (plugin_specified_by_name)

diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
index a227e99b3576811b4557dc0349e4f882425806c4..50cef8e499dcc97e9bffd918808b024e0495cb04 100644 (file)
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
@@ -72,8 +72,6 @@ public:
 
   ArchSpec GetSystemArchitecture() override;
 
-  llvm::Optional<uint32_t> GetAddressingBits() override;
-
   // Check if a given Process
   bool CanDebug(lldb::TargetSP target_sp,
                 bool plugin_specified_by_name) override;