media: ov2680: Drop unnecessary pad checks
authorHans de Goede <hdegoede@redhat.com>
Thu, 3 Aug 2023 09:33:41 +0000 (11:33 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 14 Aug 2023 18:27:57 +0000 (20:27 +0200)
Drop unnecessary pad checks in enum_mbus_code, get_fmt, set_fmt
this is already checked by check_pad() from
drivers/media/v4l2-core/v4l2-subdev.c.

Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ov2680.c

index e6c99c1..c09a0e7 100644 (file)
@@ -591,7 +591,7 @@ static int ov2680_enum_mbus_code(struct v4l2_subdev *sd,
 {
        struct ov2680_dev *sensor = to_ov2680_dev(sd);
 
-       if (code->pad != 0 || code->index != 0)
+       if (code->index != 0)
                return -EINVAL;
 
        code->code = sensor->mode.fmt.code;
@@ -606,9 +606,6 @@ static int ov2680_get_fmt(struct v4l2_subdev *sd,
        struct ov2680_dev *sensor = to_ov2680_dev(sd);
        struct v4l2_mbus_framefmt *fmt;
 
-       if (format->pad != 0)
-               return -EINVAL;
-
        fmt = __ov2680_get_pad_format(sensor, sd_state, format->pad,
                                      format->which);
 
@@ -629,9 +626,6 @@ static int ov2680_set_fmt(struct v4l2_subdev *sd,
        unsigned int width, height;
        int ret = 0;
 
-       if (format->pad != 0)
-               return -EINVAL;
-
        crop = __ov2680_get_pad_crop(sensor, sd_state, format->pad,
                                     format->which);