projects
/
platform
/
upstream
/
glog.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0312301
)
win: FAILED macro can't be used with HANDLE.
author
Fumitoshi Ukai
<ukai@google.com>
Thu, 17 Dec 2015 06:36:40 +0000
(15:36 +0900)
committer
Fumitoshi Ukai
<ukai@google.com>
Thu, 17 Dec 2015 06:36:40 +0000
(15:36 +0900)
FAILED macro is for HRESULT, not for HANDLE.
FindFirstFile returns INVALID_HANDLE_VALUE when error or not found.
https://msdn.microsoft.com/library/windows/desktop/
aa364418
(v=vs.85).aspx
fixes #79
src/logging_unittest.cc
patch
|
blob
|
history
diff --git
a/src/logging_unittest.cc
b/src/logging_unittest.cc
index
e0e3676
..
b886222
100644
(file)
--- a/
src/logging_unittest.cc
+++ b/
src/logging_unittest.cc
@@
-628,7
+628,7
@@
static void GetFiles(const string& pattern, vector<string>* files) {
LOG(FATAL) << "No directory separator.";
}
const string dirname = pattern.substr(0, index + 1);
- if (
FAILED(handle)
) {
+ if (
handle == INVALID_HANDLE_VALUE
) {
// Finding no files is OK.
return;
}