staging: rtl8712: Annotate r8712_sitesurvey_cmd()
authorMauro Dreissig <mukadr@gmail.com>
Sun, 5 Jul 2020 18:09:44 +0000 (15:09 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jul 2020 11:52:45 +0000 (13:52 +0200)
Add __must_hold() sparse annotation to r8712_sitesurvey_cmd(),
replacing the comments on top of the function.

Signed-off-by: Mauro Dreissig <mukadr@gmail.com>
Link: https://lore.kernel.org/r/20200705180944.20958-1-mukadr@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl871x_cmd.c

index 26b6180..c752307 100644 (file)
@@ -168,14 +168,9 @@ void r8712_free_cmd_obj(struct cmd_obj *pcmd)
        kfree(pcmd);
 }
 
-/*
- *     r8712_sitesurvey_cmd(~)
- *             ### NOTE:#### (!!!!)
- *             MUST TAKE CARE THAT BEFORE CALLING THIS FUNC,
- *             YOU SHOULD HAVE LOCKED pmlmepriv->lock
- */
 u8 r8712_sitesurvey_cmd(struct _adapter *padapter,
                        struct ndis_802_11_ssid *pssid)
+       __must_hold(&padapter->mlmepriv.lock)
 {
        struct cmd_obj  *ph2c;
        struct sitesurvey_parm  *psurveyPara;