drm/tegra: output: Do not put OF node twice
authorThierry Reding <treding@nvidia.com>
Fri, 13 Nov 2020 20:38:35 +0000 (21:38 +0100)
committerThierry Reding <treding@nvidia.com>
Fri, 13 Nov 2020 20:38:35 +0000 (21:38 +0100)
The original patch for commit 3d2e7aec7013 ("drm/tegra: output: Don't
leak OF node on error") contained this hunk, but it was accidentally
dropped during conflict resolution. This causes use-after-free errors
on devices that use an I2C controller for HDMI DDC/CI on Tegra210 and
later.

Fixes: 3d2e7aec7013 ("drm/tegra: output: Don't leak OF node on error")
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/tegra/output.c

index 5a4fd0d..47d26b5 100644 (file)
@@ -129,7 +129,6 @@ int tegra_output_probe(struct tegra_output *output)
 
                if (!output->ddc) {
                        err = -EPROBE_DEFER;
-                       of_node_put(ddc);
                        return err;
                }
        }