selftests/bpf: Build urandom_read with LDFLAGS and LDLIBS
authorDaniel Díaz <daniel.diaz@linaro.org>
Wed, 22 Jan 2020 16:44:24 +0000 (17:44 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Wed, 22 Jan 2020 16:45:29 +0000 (17:45 +0100)
During cross-compilation, it was discovered that LDFLAGS and
LDLIBS were not being used while building binaries, leading
to defaults which were not necessarily correct.

OpenEmbedded reported this kind of problem:

  ERROR: QA Issue: No GNU_HASH in the ELF binary [...], didn't pass LDFLAGS?

Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
tools/testing/selftests/bpf/Makefile

index be8fe404a086c598094bbd9f891900fb25494dff..5f41f5bd8033fa22449e3e1c62e1d1ccbbc85749 100644 (file)
@@ -122,7 +122,7 @@ $(OUTPUT)/%:%.c
 
 $(OUTPUT)/urandom_read: urandom_read.c
        $(call msg,BINARY,,$@)
-       $(CC) -o $@ $< -Wl,--build-id
+       $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) -Wl,--build-id
 
 $(OUTPUT)/test_stub.o: test_stub.c $(BPFOBJ)
        $(call msg,CC,,$@)