eina: Applied NULL check
authorAnand <anand.km@samsung.com>
Tue, 24 Nov 2015 08:50:09 +0000 (17:50 +0900)
committerJean-Philippe Andre <jp.andre@samsung.com>
Tue, 24 Nov 2015 08:50:21 +0000 (17:50 +0900)
Summary:
In _eina_list_setup_accounting function
{
...
...
if (!list->accounting)
     goto on_error;
...
...
on_error:
   _eina_list_mempool_list_free(list);
}

_eina_list_mempool_list_free function deference the "list->accounting"
variable which is already NULL.

Reviewers: JackDanielZ, jpeg

Reviewed By: jpeg

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D3376

src/lib/eina/eina_list.c

index 6a73243..5c926ea 100644 (file)
@@ -209,9 +209,12 @@ _eina_list_mempool_list_free(Eina_List *list)
 {
    EINA_MAGIC_CHECK_LIST(list);
 
-   list->accounting->count--;
-   if (list->accounting->count == 0)
-     _eina_list_mempool_accounting_free(list->accounting);
+   if (list->accounting)
+     {
+        list->accounting->count--;
+        if (list->accounting->count == 0)
+          _eina_list_mempool_accounting_free(list->accounting);
+     }
 
    EINA_MAGIC_SET(list, EINA_MAGIC_NONE);
    eina_mempool_free(_eina_list_mp, list);