Fix node::Buffer API changes.
authorHaojian Wu <hokein.wu@gmail.com>
Tue, 4 Aug 2015 08:50:33 +0000 (16:50 +0800)
committerCheng Zhao <zcbenz@gmail.com>
Tue, 11 Aug 2015 01:48:29 +0000 (09:48 +0800)
atom/common/api/atom_api_native_image.cc
chromium_src/chrome/browser/printing/print_preview_message_handler.cc

index 40a73a7..79fc0c0 100644 (file)
@@ -148,17 +148,18 @@ mate::ObjectTemplateBuilder NativeImage::GetObjectTemplateBuilder(
 
 v8::Local<v8::Value> NativeImage::ToPNG(v8::Isolate* isolate) {
   scoped_refptr<base::RefCountedMemory> png = image_.As1xPNGBytes();
-  return node::Buffer::New(isolate,
-                           reinterpret_cast<const char*>(png->front()),
-                           png->size());
+  return node::Buffer::Copy(isolate,
+                            reinterpret_cast<const char*>(png->front()),
+                            static_cast<size_t>(png->size())).ToLocalChecked();
 }
 
 v8::Local<v8::Value> NativeImage::ToJPEG(v8::Isolate* isolate, int quality) {
   std::vector<unsigned char> output;
   gfx::JPEG1xEncodedDataFromImage(image_, quality, &output);
-  return node::Buffer::New(isolate,
-                           reinterpret_cast<const char*>(&output.front()),
-                           output.size());
+  return node::Buffer::Copy(
+      isolate,
+      reinterpret_cast<const char*>(&output.front()),
+      static_cast<size_t>(output.size())).ToLocalChecked();
 }
 
 std::string NativeImage::ToDataURL() {
index ca70ac2..613f3f2 100644 (file)
@@ -125,8 +125,8 @@ void PrintPreviewMessageHandler::RunPrintToPDFCallback(
   v8::Locker locker(isolate);
   v8::HandleScope handle_scope(isolate);
   if (data) {
-    v8::Local<v8::Value> buffer = node::Buffer::Use(isolate,
-        data, static_cast<size_t>(data_size));
+    v8::Local<v8::Value> buffer = node::Buffer::New(isolate,
+        data, static_cast<size_t>(data_size)).ToLocalChecked();
     print_to_pdf_callback_map_[request_id].Run(v8::Null(isolate), buffer);
   } else {
     v8::Local<v8::String> error_message = v8::String::NewFromUtf8(isolate,