Avoid using vmalloc for small hash tables.
authorThomas Hellstrom <thomas-at-tungstengraphics-dot-com>
Mon, 21 Aug 2006 15:02:44 +0000 (17:02 +0200)
committerThomas Hellstrom <thomas-at-tungstengraphics-dot-com>
Mon, 21 Aug 2006 15:02:44 +0000 (17:02 +0200)
linux-core/drm_hashtab.c
linux-core/drm_hashtab.h

index 4806113..4059922 100644 (file)
@@ -43,7 +43,16 @@ int drm_ht_create(drm_open_hash_t *ht, unsigned int order)
        ht->size = 1 << order;
        ht->order = order;
        ht->fill = 0;
-       ht->table = vmalloc(ht->size*sizeof(*ht->table));
+       ht->table = NULL;
+       ht->use_vmalloc = ((ht->size * sizeof(*ht->table)) > 4*PAGE_SIZE);
+       if (!ht->use_vmalloc) {
+               ht->table = drm_calloc(ht->size, sizeof(*ht->table), 
+                                      DRM_MEM_HASHTAB);
+       } 
+       if (!ht->table) {
+               ht->use_vmalloc = 1;
+               ht->table = vmalloc(ht->size*sizeof(*ht->table));       
+       } 
        if (!ht->table) {
                DRM_ERROR("Out of memory for hash table\n");
                return -ENOMEM;
@@ -183,7 +192,11 @@ int drm_ht_remove_item(drm_open_hash_t *ht, drm_hash_item_t *item)
 void drm_ht_remove(drm_open_hash_t *ht)
 {
        if (ht->table) {
-               vfree(ht->table);
+               if (ht->use_vmalloc) 
+                       vfree(ht->table);
+               else
+                       drm_free(ht->table, ht->size*sizeof(*ht->table), 
+                                DRM_MEM_HASHTAB);
                ht->table = NULL;
        }
 }
index 40afec0..613091c 100644 (file)
@@ -47,6 +47,7 @@ typedef struct drm_open_hash{
        unsigned int order;
        unsigned int fill;
        struct hlist_head *table;
+       int use_vmalloc;
 } drm_open_hash_t;