ASOC: SOF: Intel: hda-codec: move unused label to correct position
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 13 Aug 2020 17:58:35 +0000 (12:58 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 17 Aug 2020 14:42:56 +0000 (15:42 +0100)
Cppcheck reports the following warning:

sound/soc/sof/intel/hda-codec.c:191:1: style: Label 'error' is not
used. [unusedLabel]

This label is indeed only used conditionally, move it where it's
actually used.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200813175839.59422-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda-codec.c

index 2c5c451..119aa9f 100644 (file)
@@ -178,6 +178,11 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address,
        }
 
        return ret;
+
+error:
+       snd_hdac_ext_bus_device_exit(hdev);
+       return -ENOENT;
+
 #else
        hdev = devm_kzalloc(sdev->dev, sizeof(*hdev), GFP_KERNEL);
        if (!hdev)