rxrpc: rxperf: Fix uninitialised variable
authorDavid Howells <dhowells@redhat.com>
Thu, 15 Dec 2022 16:20:46 +0000 (16:20 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 19 Dec 2022 09:51:31 +0000 (09:51 +0000)
Dan Carpenter sayeth[1]:

  The patch 75bfdbf2fca3: "rxrpc: Implement an in-kernel rxperf server
  for testing purposes" from Nov 3, 2022, leads to the following Smatch
  static checker warning:

net/rxrpc/rxperf.c:337 rxperf_deliver_to_call()
error: uninitialized symbol 'ret'.

Fix this by initialising ret to 0.  The value is only used for tracing
purposes in the rxperf server.

Fixes: 75bfdbf2fca3 ("rxrpc: Implement an in-kernel rxperf server for testing purposes")
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Link: http://lists.infradead.org/pipermail/linux-afs/2022-December/006124.html
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rxrpc/rxperf.c

index 66f5eea..d33a109 100644 (file)
@@ -275,7 +275,7 @@ static void rxperf_deliver_to_call(struct work_struct *work)
        struct rxperf_call *call = container_of(work, struct rxperf_call, work);
        enum rxperf_call_state state;
        u32 abort_code, remote_abort = 0;
-       int ret;
+       int ret = 0;
 
        if (call->state == RXPERF_CALL_COMPLETE)
                return;