Staging: rtl8723au: Use put_unaligned_le32
authorShraddha Barke <shraddha.6596@gmail.com>
Fri, 23 Oct 2015 14:27:52 +0000 (19:57 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Oct 2015 02:44:30 +0000 (19:44 -0700)
Introduce the use of function put_unaligned_le32.

A simplified version of Coccinelle semantic patch used -

@@ identifier tmp; expression ptr; expression y,e; type T; @@

- tmp = cpu_to_le32(y);

  <+... when != tmp
- memcpy(ptr, (T)&tmp, ...);
+ put_unaligned_le32(y,ptr);
  ...+>
? tmp = e

@@ type T; identifier tmp; @@

- T tmp;
...when != tmp

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c

index 9733aa6..1662c03 100644 (file)
@@ -127,8 +127,7 @@ int rtl8723a_set_raid_cmd(struct rtw_adapter *padapter, u32 mask, u8 arg)
        u8 buf[5];
 
        memset(buf, 0, 5);
-       mask = cpu_to_le32(mask);
-       memcpy(buf, &mask, 4);
+       put_unaligned_le32(mask, buf);
        buf[4]  = arg;
 
        FillH2CCmd(padapter, MACID_CONFIG_EID, 5, buf);