ksmbd: Replace one-element array with flexible-array member
authorGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 21 Jun 2023 21:12:42 +0000 (15:12 -0600)
committerSteve French <stfrench@microsoft.com>
Mon, 26 Jun 2023 05:07:04 +0000 (00:07 -0500)
One-element arrays are deprecated, and we are replacing them with flexible
array members instead. So, replace one-element array with flexible-array
member in struct smb_negotiate_req.

This results in no differences in binary output.

Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/KSPP/linux/issues/317
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smb_common.h

index 6b0d5f1..aeca0f4 100644 (file)
@@ -200,7 +200,7 @@ struct smb_hdr {
 struct smb_negotiate_req {
        struct smb_hdr hdr;     /* wct = 0 */
        __le16 ByteCount;
-       unsigned char DialectsArray[1];
+       unsigned char DialectsArray[];
 } __packed;
 
 struct smb_negotiate_rsp {